Use Mollweide Projection for Shell Slices #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a comment: the new Python interface from #274 will also support Mollweide and other projections from matplotlib natively. |
tukss
requested changes
Sep 12, 2022
There was a problem hiding this comment.
Can you remove your changes to YT_volrender_tutorial2.ipynb from the PR? This is just some changed metadata, that we don't want to change every time someone commits something. I can show you how to remove it from history with git rebase if you want.
The Mollweide plot works totally fine. We might want to pass rasterized=True to the pcolormesh call. Especially for high resolution data, this really reduces the size of the PDF file. 192 kB vs. 12 MB in my case.
|
We need to rebase this fix the build error. |
Changed plot_Shell_Slices.py to make Mollweide plots
tukss
force-pushed
the
fix_shellplots
branch
from
d5fc771
to
ab29098
Compare
Newer versions of matplotllib throw a warning when we use pcolormesh without adding a shading keyword. This adds shading=auto to all instances of pcolormesh
tukss
force-pushed
the
fix_shellplots
branch
from
ab29098
to
2552746
Compare
tukss
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed plot_Shell_Slices.py to make Mollweide plots