A draft pull request showing progress on the extra scalar field branch #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After resolving conflicts and attempting to move code appropriately this compiles but has not been tested.
…sing segfaults. Note that the additional scalar field is currently mandatory.
Fix an error in bcs for svar and allow initial conditions to be specified (only through generic input). Temporarily add a test for debugging purposes.
…tial Conditions. Fixes segfault found using intel compiler.
…ons of all the parameters. c(12) has now been taken for the buoyancy coefficient.
But... it's no longer possible to get the benchmark case to have the same timestep as the generic input cases because of the rotation timescale imposed causing max_time_step to be overwritten. Therefore I've disabled the benchmark comparison and just compare the T and chi cases.
… opposite to the sign of temperature
|
This was superseded by #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended for review (yet)