Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 12-spatial-cv.Rmd #805

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Update 12-spatial-cv.Rmd #805

merged 1 commit into from
Jun 8, 2022

Conversation

babayoshihiko
Copy link
Contributor

When I ran the code, rr_glm did not exist. Maybe rr_spcv_glm?

The code chunk has eval=F, so it will not affect building.

When I ran the code, `rr_glm` did not exist. Maybe `rr_spcv_glm`?
@Nowosad Nowosad requested a review from jannes-m June 6, 2022 00:49
Copy link
Collaborator

@jannes-m jannes-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting

Copy link
Collaborator

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A danger of eval=FALSE. Definite fix 👍

@Robinlovelace Robinlovelace merged commit f021cb2 into geocompx:main Jun 8, 2022
@babayoshihiko babayoshihiko deleted the patch-1 branch July 8, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants