Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related to #798 #799

Merged
merged 2 commits into from
May 14, 2022
Merged

related to #798 #799

merged 2 commits into from
May 14, 2022

Conversation

Nowosad
Copy link
Member

@Nowosad Nowosad commented May 14, 2022

No description provided.

Copy link
Contributor

@defuneste defuneste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better, specially L507. Let me try to improve a bit L524 (and see now, if I understand it correctly).

Each input simple feature object with only one element (first column) is transformed directly into another geometry type.

--->

When a simple feature object with just one element is used in input it is transformed directly into another geometry type.

And L527

You can see that, for example, when you cast a multipoint consisting of five pairs of coordinates into a point.

--->

You can see that, for example, when you cast a multipoint consisting of five pairs of coordinates into a point (one pair of coordinates).

Correct ?

@Robinlovelace
Copy link
Collaborator

To keep up momentum I'm going to merge this. We can see how it looks in the updated text and then decide if it fixes the issue. Any further comments welcome @defuneste. I think the table still could be explained better in terms of exactly what the inputs in the first column are. Any ideas on that? Far out idea is to create a small plot representing each input...

@Robinlovelace Robinlovelace self-requested a review May 14, 2022 19:35
One important difference is the conversion between multi-types to non-multi-types.
As a result of this process, multi-objects are split into many non-multi-objects.
As a result of this process, multi-objects of `sfc` or `sf` are split into many non-multi-objects.

Table \@ref(tab:sfs-st-cast) shows possible geometry type transformations on simple feature objects.
Each input simple feature object with only one element (first column) is transformed directly into another geometry type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be explained more clearly.

@Robinlovelace Robinlovelace merged commit 6d0c07a into main May 14, 2022
@Robinlovelace Robinlovelace deleted the castexp branch May 14, 2022 19:35
@defuneste
Copy link
Contributor

https://github.com/Robinlovelace/geocompr/blob/main/05-geometry-operations.Rmd#L524-L527

This seems good to me and showed that I misunderstood the first version!

I do not see how we can improve the table. An exercise on it could be an option but E6 is already a bit on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants