Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Binder #570

Closed
Robinlovelace opened this issue Sep 20, 2020 · 16 comments
Closed

Issues with Binder #570

Robinlovelace opened this issue Sep 20, 2020 · 16 comments
Assignees

Comments

@Robinlovelace
Copy link
Collaborator

rocker-org/binder#42 (comment)

@Robinlovelace
Copy link
Collaborator Author

It's down this morning:

image

Is this also down for you @Nowosad ?

@Robinlovelace
Copy link
Collaborator Author

This link seems to spin-up but does not deploy: https://mybinder.org/v2/gh/robinlovelace/geocompr/master?urlpath=rstudio

@Nowosad
Copy link
Member

Nowosad commented Sep 24, 2020

Yep, I have the same error.

@Robinlovelace
Copy link
Collaborator Author

Heads-up @Nowosad and @jannes-m could you try this out: https://rstudio.cloud/project/1642300

I think most of the book can be tested there in browser but not sure if others can access it. If so I reckon it's worth adding a badge. Still trying to fix binder issues...

@Nowosad
Copy link
Member

Nowosad commented Oct 31, 2020

I was able to access it (after login):

2020-10-31_06-48

Robinlovelace added a commit that referenced this issue Oct 31, 2020
@jannes-m
Copy link
Collaborator

jannes-m commented Oct 31, 2020 via email

@Robinlovelace
Copy link
Collaborator Author

Many thanks guys, the updated texts is as follows:
Launch Rstudio Binder

You can also have a play with the repo in RStudio Cloud by clicking on this link (requires log-in):

Launch Rstudio Cloud

Any further tests/comments/changes very welcome.

@Robinlovelace
Copy link
Collaborator Author

Interesting observation - the rendering is different when you build the book in binder, not sure why:

image

Heads-up all, especially @Nowosad, I had to make these changes for it to build in binder, any objections to merging this? #586

@Nowosad
Copy link
Member

Nowosad commented Nov 2, 2020

Hi @Robinlovelace, I am not a very active user of Binder, therefore, if you are happy with the changes - so am I.

Regarding the rendering style - I have no idea. Can you explain me how to reproduce this issue?

@Robinlovelace
Copy link
Collaborator Author

Hi @Nowosad to reproduce the issue, click here and build the book: https://mybinder.org/v2/gh/robinlovelace/geocompr/master?urlpath=rstudio

@Nowosad
Copy link
Member

Nowosad commented Nov 2, 2020

Thanks - I followed your guidelines and get a proper results (see below). To create an html version, I just run make html in the RStudio terminal.

2020-11-02_12-13

@Robinlovelace
Copy link
Collaborator Author

Interesting... May have just been a one-off glitch. Good to know we can reproduce the entire book in-browser with Binder in any case, thanks for testing.

@Robinlovelace
Copy link
Collaborator Author

Since the latest commit it's working, but without plots. See
image

Robinlovelace added a commit that referenced this issue Sep 24, 2021
Robinlovelace added a commit that referenced this issue Sep 24, 2021
@Robinlovelace
Copy link
Collaborator Author

image

Latest commit from r-conda.

@Robinlovelace
Copy link
Collaborator Author

Latest Binder build with a few extra install.packages() calls allowed the entire book to built in Binder 🎉

image

@Robinlovelace
Copy link
Collaborator Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants