Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #32

Merged
merged 6 commits into from
Apr 18, 2022
Merged

Update dependencies #32

merged 6 commits into from
Apr 18, 2022

Conversation

Robinlovelace
Copy link
Contributor

No description provided.

@jannes-m
Copy link
Contributor

I have added a few missing packages and hope that I haven't forgotten one but we will find out soon enough, I guess or maybe not since all the ml stuff is handled with eval=FALSE to avoid super-long computation times in the CI.

@Robinlovelace
Copy link
Contributor Author

Thanks @jannes-m I'm seeing this issue in the CI:

Error: Error: Missing commas separating Remotes: 'mlr-org/mlr3extralearners

Looks like my earlier commits were also failing...

@jannes-m
Copy link
Contributor

jannes-m commented Apr 17, 2022

Sorry, forgetting the commas was my bad. This is fixed. One reason why the book won't built now is that the solutions of c14 (now c15) cannot be compiled. This is because we have deleted the old mlr deps from the DESCRIPTION.

@Nowosad
Copy link
Member

Nowosad commented Apr 18, 2022

Hi @jannes-m -- please also update the package version and then I think it is ready for the merge

@Nowosad Nowosad merged commit 013a052 into master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants