Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to project #61

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Add license to project #61

merged 2 commits into from
Nov 25, 2022

Conversation

lonvia
Copy link
Contributor

@lonvia lonvia commented Jan 6, 2022

As discussed in #60, this adds a license to the project. The basic license is MIT. In addition, there is a special exception in the README that puts all tests into the public domain to make them as reusable as possible.

I would kindly request that all that have contributed so far explicitly approve this PR if the license is fine with you. In particular, please make sure that tests that you have contributed can be put into the public domain. If you have reservations or questions, please comment on #60 or get in touch with me directly.

Contributors list according to github: @yohanboniface @nlehuby @hbruch @karussell @kinnou02 @antoine-de @jfgigand
Please approve this PR or comment, if this change is okay with you.

README.md Outdated

As a special exception, the test cases under `geocoder_tester/world/` are
considered to be in the public domain. You may use them without any
restrictions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used 3rd parties datasets (Wikidata, OpenFlights, etc) to create some test cases, so some of them may not be considered to be in the public domain. For instance: https://github.com/geocoders/geocoder-tester/blob/master/geocoder_tester/world/poi/license.md
Maybe add "unless otherwise specified in the test directory readme" here ?

OpenFlights also comes with a more retrictive ODbL license.
@lonvia
Copy link
Contributor Author

lonvia commented Jan 10, 2022

I have now changed the text as per @nlehuby suggest and added an explicit attribution for wikidata and OpenFlights.

However, this makes me realise that quite a bit of the test data is based on OpenStreetMap data, probably more than what would allow us to claim it as an insubstantial abstract.

@yohanboniface yohanboniface merged commit a8094d3 into geocoders:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants