-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to extension_metadata()
instead of extension_field()
?
#218
Comments
Now extension metadata only contains extension name, is extension_metadata method still needed? If needed, I can add it. |
This crate hasn't added support yet for extension metadata. We will need to add support at some point for it to keep track of the column's coordinate system information, see https://geoarrow.org/extension-types#extension-metadata |
Can you give a review on #224? I'd like to support ewkb after this merged. |
Implementation of https://github.com/geoarrow/geoarrow/blob/main/extension-types.md#extension-metadata Follow ups: - Don't include `ARROW:extension:metadata` key if neither `crs` nor `edges` exists - Allow python bindings to pass in CRS - Pass on CRS in GeoParquet reader Closes #218,
It's not quite accurate to return
extension_field()
because that implies that you know the name of the field and its nullability. We need to expose both the data type and the extension metadata because arrow-rs doesn't have aDataType::Extension
but it might be clearer to expose just those instead of wrapping them in aField
with an empty column name. So that would be:The text was updated successfully, but these errors were encountered: