Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heatmap example #133

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

vgeorge
Copy link

@vgeorge vgeorge commented Aug 12, 2024

This adds a minimal example for a Heatmap layer, currently a work in progress. The main motivation is to provide an easy, reusable scenario to debug the Lonboard upgrade to Deck.gl v9.

Changes:

  • Upgraded Deck.gl to v9.0.27
  • Added a Heatmap example based on the Point example

I added two scenarios for instantiating the GeoArrowHeatmapLayer component:

  • Scenario 1: No properties other than id and data are passed. Given that the type definition for the props did not raise errors, I would expect this to render something. However, the console instead displays deck: initialization of HeatmapLayer({id: 'geoarrow-heatmap-geoarrow-heatmap-geoarrow-heatmap-0'}): buffer is null TypeError: buffer is null.

  • Scenario 2: In this issue, others reported a similar problem, and the fix that worked for some was related to the getWeight parameter. I set it to return a random positive number, which:

    • Did not result in a constructor error.
    • Printed Model "geoarrow-heatmap-geoarrow-heatmap-geoarrow-heatmap-0-triangle-layer: Ignoring constant supplied for unknown attribute "instancePickingColors" to the console.
    • Did not render a heatmap.

It is not clear to me if the buffer fix PR is available in v9.0.27. The author mentioned it depends on the UBO work PR, which hasn't been merged yet.

@kylebarron please let me know if you have any thoughts on this.

@kylebarron
Copy link
Member

It is not clear to me if the buffer fix PR is available in v9.0.27. The author mentioned it depends on the UBO work PR, which hasn't been merged yet.

Well it looks like there was a separate fix here: visgl/deck.gl#9037. In general it's kinda hard to tell sometimes when PRs are also cherry picked to the release branch. Just because it's been merged to the master branch doesn't mean it's included in the 9.0 release branch.

@kylebarron
Copy link
Member

See my comment here visgl/deck.gl#8960 (comment) where I forked the previous HeatmapLayer repro that someone else had reported, updated to the latest deck.gl version, and am still getting the same issue. Let's follow that thread and see what other maintainers say about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants