Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimal example for a Heatmap layer, currently a work in progress. The main motivation is to provide an easy, reusable scenario to debug the Lonboard upgrade to Deck.gl v9.
Changes:
v9.0.27
I added two scenarios for instantiating the
GeoArrowHeatmapLayer
component:Scenario 1: No properties other than
id
anddata
are passed. Given that the type definition for the props did not raise errors, I would expect this to render something. However, the console instead displaysdeck: initialization of HeatmapLayer({id: 'geoarrow-heatmap-geoarrow-heatmap-geoarrow-heatmap-0'}): buffer is null TypeError: buffer is null
.Scenario 2: In this issue, others reported a similar problem, and the fix that worked for some was related to the
getWeight
parameter. I set it to return a random positive number, which:Model "geoarrow-heatmap-geoarrow-heatmap-geoarrow-heatmap-0-triangle-layer: Ignoring constant supplied for unknown attribute "instancePickingColors"
to the console.It is not clear to me if the buffer fix PR is available in
v9.0.27
. The author mentioned it depends on the UBO work PR, which hasn't been merged yet.@kylebarron please let me know if you have any thoughts on this.