Better error when DOCKER_HOST invalid

At the moment something like DOCKER_HOST=foo results in an IAE and startup failing.
geoand · Apr 20, 2022 · 6e50b03 · 6e50b03
1 parent 122467f
commit 6e50b03
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/IsDockerWorking.java b/core/deployment/src/main/java/io/quarkus/deployment/IsDockerWorking.java
@@ -81,6 +81,9 @@ public Result get() {
                 Object dockerClientFactoryInstance = dockerClientFactoryClass.getMethod("instance").invoke(null);
                 boolean isAvailable = (boolean) dockerClientFactoryClass.getMethod("isDockerAvailable")
                         .invoke(dockerClientFactoryInstance);
+                if (!isAvailable) {
+                    compressor.closeAndDumpCaptured();
+                }
                 return isAvailable ? Result.AVAILABLE : Result.UNAVAILABLE;
             } catch (ClassNotFoundException | NoSuchMethodException | InvocationTargetException | IllegalAccessException e) {
                 if (!silent) {
@@ -117,7 +120,7 @@ public Result get() {
                                 "Unable to connect to DOCKER_HOST URI %s, make sure docker is running on the specified host",
                                 dockerHost);
                     }
-                } catch (URISyntaxException e) {
+                } catch (URISyntaxException | IllegalArgumentException e) {
                     LOGGER.warnf("Unable to parse DOCKER_HOST URI %s, it will be ignored for working docker detection",
                             dockerHost);
                 }