Skip to content

Commit

Permalink
Ensure that Google Cloud Functions and Jib extensions work together
Browse files Browse the repository at this point in the history
  • Loading branch information
geoand committed May 12, 2023
1 parent ba59762 commit 3448ff8
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
import io.quarkus.deployment.pkg.builditem.JarBuildItem;
import io.quarkus.deployment.pkg.builditem.NativeImageBuildItem;
import io.quarkus.deployment.pkg.builditem.OutputTargetBuildItem;
import io.quarkus.deployment.pkg.builditem.UberJarRequiredBuildItem;
import io.quarkus.deployment.pkg.builditem.UpxCompressedBuildItem;
import io.quarkus.deployment.pkg.steps.JarResultBuildStep;
import io.quarkus.deployment.pkg.steps.NativeBuild;
Expand Down Expand Up @@ -150,6 +151,7 @@ public void buildFromJar(ContainerImageConfig containerImageConfig, JibConfig ji
Optional<ContainerImagePushRequestBuildItem> pushRequest,
List<ContainerImageLabelBuildItem> containerImageLabels,
Optional<AppCDSResultBuildItem> appCDSResult,
List<UberJarRequiredBuildItem> uberJarRequired,
BuildProducer<ArtifactResultBuildItem> artifactResultProducer,
BuildProducer<ContainerImageBuilderBuildItem> containerImageBuilder) {

Expand All @@ -161,7 +163,8 @@ public void buildFromJar(ContainerImageConfig containerImageConfig, JibConfig ji

JibContainerBuilder jibContainerBuilder;
String packageType = packageConfig.type;
if (packageConfig.isLegacyJar() || packageType.equalsIgnoreCase(PackageConfig.BuiltInType.UBER_JAR.getValue())) {
if (packageConfig.isLegacyJar() || packageType.equalsIgnoreCase(PackageConfig.BuiltInType.UBER_JAR.getValue())
|| !uberJarRequired.isEmpty()) {
jibContainerBuilder = createContainerBuilderFromLegacyJar(determineBaseJvmImage(jibConfig, compiledJavaVersion),
jibConfig, containerImageConfig,
sourceJar, outputTarget, mainClass, containerImageLabels);
Expand Down

0 comments on commit 3448ff8

Please sign in to comment.