Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to use local print server with headless puppeteer #1181

Draft
wants to merge 3 commits into
base: poc-maplibre-layer
Choose a base branch
from
Draft

add option to use local print server with headless puppeteer #1181

wants to merge 3 commits into from

Conversation

mki-c2c
Copy link

@mki-c2c mki-c2c commented Jan 6, 2025 •
edited by github-actions bot
Loading

pakb and others added 3 commits September 20, 2024 09:03
@pakb
[POC] MapLibre layer
2559300 
replaces all BG layers with a VectorTile equivalent
switch to mercator as default projection to make it happen (not possible yet to mix projection systems, needs some work done on the geoblocks/ol-maplibre-layer library)

fix INT staging URL : no sys service serves theses styles yet
@pakb
[POC] Support on-the-fly LV95 reprojection
1925e79 
copying geoblocks/ol-maplibre-layer/ locally to be able to edit it and add the on the fly capabilities (will create a PR there when done)

Making our coordinate system calculate resolution without threshold (especially for LV95) so that it can then be used to calculate a mercator zoom level
@mki-c2c
add option to use local print server with headless puppeteer
421c38c
@mki-c2c mki-c2c marked this pull request as ready for review January 6, 2025 13:28
@mki-c2c mki-c2c marked this pull request as draft January 6, 2025 13:28
@cypress Cypress
Copy link

cypress bot commented Jan 6, 2025

web-mapviewer    Run #4184

Run Properties:  status check failed Failed #4184  •  git commit 421c38c535: add option to use local print server with headless puppeteer
Project web-mapviewer
Branch Review puppeteer_poc
Run status status check failed Failed #4184
Run duration 32m 21s
Commit git commit 421c38c535: add option to use local print server with headless puppeteer
Committer Moritz Kirmse
View all properties for this run ↗︎
Test results
Tests that failed  Failures 129
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 34
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Tests for review

Failed  layers.cy.js • 28 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test of layer handling > Layer in URL at app startup > starts without any visible layer added opening the app without layers URL param Screenshots
Test of layer handling > Layer in URL at app startup > adds a layers with config to the map when opening the app layers URL param Screenshots
Test of layer handling > Layer in URL at app startup > uses the default timestamp of a time enabled layer when not specified in the URL Screenshots
Test of layer handling > Layer in URL at app startup > sets the timestamp of a layer when specified in the layers URL param Screenshots
... > reads and adds an external WMS correctly Screenshots
... > reads and adds an external WMTS correctly Screenshots
... > handles errors correctly Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background to the topic default if none is defined in the URL, even if a layer (out of topic scope) is defined in it Screenshots
Test of layer handling > Background layer in URL at app startup > sets the background according to the URL param if present at startup Screenshots
The first 10 failed tests are shown, see all 28 tests in Cypress Cloud.
Failed  drawing.cy.js • 11 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > KML management > deletes the drawing when confirming the delete modal Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer in the layer list / URL params correctly Test Replay Screenshots
Drawing module tests > KML management > keeps the KML after a page reload, and creates a copy if it is then edited Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup from a legacy URL Test Replay Screenshots
Drawing module tests > others > doesn't save an empty drawing (if not modified) Test Replay Screenshots
Drawing module tests > others > can export the drawing/profile in multiple formats Test Replay Screenshots
Drawing module tests > others > generates short links when sharing a drawing Test Replay Screenshots
Drawing module tests > others > shows a profile of a line/measure coming from service-alti data Test Replay Screenshots
The first 10 failed tests are shown, see all 11 tests in Cypress Cloud.
Failed  legacyParamImport.cy.js • 18 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Test on legacy param import > Coordinates import > transfers valid params to the hash part without changing them Test Replay Screenshots
Test on legacy param import > Coordinates import > loads correctly if params are already behind the hash Test Replay Screenshots
Test on legacy param import > Coordinates import > reproject LV95 coordinates param to EPSG:4326 Test Replay Screenshots
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV95 Test Replay Screenshots
Test on legacy param import > Coordinates import > center where expected when given a X, Y coordinate in LV03 Test Replay Screenshots
Test on legacy param import > Layers import > Combines all old layers_*** params into the new one Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy param Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param Test Replay Screenshots
Test on legacy param import > Layers import > don't keep KML adminId in URL after import Test Replay Screenshots
Test on legacy param import > Layers import > is able to import an external KML from a legacy adminId query param with other layers Test Replay Screenshots
The first 10 failed tests are shown, see all 18 tests in Cypress Cloud.
Failed  importToolFile.cy.js • 3 failed tests • e2e/electron/mobile

View Output

Test Artifacts
The Import File Tool > Import KML file Test Replay Screenshots
The Import File Tool > Import KML file error handling Test Replay Screenshots
The Import File Tool > Import GPX file Test Replay Screenshots
Failed  print.cy.js • 7 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Testing print > Print UI > should populate the UI with the capabilities from mapfishprint Test Replay Screenshots
Testing print > Send print request > should send a print request to mapfishprint (basic parameters) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request to mapfishprint (with layers added) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (with KML layer) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint with GPX layer Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (icon and label) Test Replay Screenshots
Testing print > Send print request with layers > should send a print request correctly to mapfishprint (KML from old geoadmin) Test Replay Screenshots

The first 5 failed specs are shown, see all 29 specs in Cypress Cloud.

@pakb pakb force-pushed the poc-maplibre-layer branch from 1925e79 to 479db78 Compare January 8, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mki-c2c @pakb