PB-1146: Zoom in on geolocation first activation #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltkum
force-pushed
the
fix-PB-1146-zoom-on-location-geolocation
branch
from
e42cfa8 to
074103f
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1146-zoom-on-location-geolocation
|
| Run status |
|
| Run duration | 04m 20s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
215
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
Dec 10, 2024
ltkum
force-pushed
the
fix-PB-1146-zoom-on-location-geolocation
branch
from
074103f to
22b29ce
Compare
pakb
approved these changes
Dec 10, 2024
Issue : When activating geolocation for the first time, we do not zoom on the location Fix : We use the already existing boolean to check if we're on the geolocation first activation. If that's the case, we now zoom at zoom level 8
ltkum
force-pushed
the
fix-PB-1146-zoom-on-location-geolocation
branch
from
22b29ce to
4a3d9fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : When activating geolocation for the first time, we do not zoom on the location
Fix : We use the already existing boolean to check if we're on the geolocation first activation. If that's the case, we now zoom at zoom level 8
Test link