PB-1176: Fix cesium static assets location #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1176-cesium-build
|
| Run status |
|
| Run duration | 04m 03s |
| Commit |
|
| Committer | Brice Schaffner |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
215
|
| View all changes introduced in this branch ↗︎ | |
pakb
approved these changes
Dec 10, 2024
vite.config.mts
Outdated
| @@ -21,6 +21,7 @@ if (!appVersion) { | |||
| const __dirname = dirname(fileURLToPath(import.meta.url)) | |||
| const cesiumSource = `${__dirname}/node_modules/cesium/Source` | |||
| const cesiumWorkers = '../Build/Cesium/Workers' | |||
There was a problem hiding this comment.
not sure it would also be a good idea to replace this relative path with something similar to the line above
There was a problem hiding this comment.
but then we need to modify further down. However I'll remove this cesiumWorkers constant as it is used only in one place and use the path hardcoced like for the other assets, it make the code easier to understand.
During the build the cesium static assets were put into the root of the application. This was an issue for our deployment strategy were we have all assets in a versioned folder and were we first deploy the versioned folder before deploying the entry point index.html that point to the versioned folder. This allow for a pseudo atomic deployment. So now all the cesium static assets have been placed into VERSION/cesium/ path.
ltshb
force-pushed
the
feat-PB-1176-cesium-build
branch
from
7ae01a7 to
3387418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the build the cesium static assets were put into the root of the application.
This was an issue for our deployment strategy were we have all assets in a
versioned folder and were we first deploy the versioned folder before deploying
the entry point index.html that point to the versioned folder. This allow for
a pseudo atomic deployment.
So now all the cesium static assets have been placed into VERSION/cesium/ path.
Test link