Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1204 Cesium WMS as composable and tested with Cypress #1148

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

pakb
Copy link
Contributor

@pakb pakb commented Nov 29, 2024

fixing an issue with preview layer being kept on the map after added through the catalogue component

Test link

Copy link

cypress bot commented Nov 29, 2024

web-mapviewer    Run #4092

Run Properties:  status check passed Passed #4092  •  git commit bb109a7ac8: PB-1204: fix unrelated test failure on import KML
Project web-mapviewer
Branch Review feat-PB-1204-cesium-wms-composable
Run status status check passed Passed #4092
Run duration 04m 56s
Commit git commit bb109a7ac8: PB-1204: fix unrelated test failure on import KML
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 216
View all changes introduced in this branch ↗︎

@pakb pakb force-pushed the feat-PB-1204-cesium-wms-composable branch 3 times, most recently from c685878 to 8543af7 Compare December 6, 2024 12:24
Copy link
Contributor

@ismailsunni ismailsunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pakb added 2 commits December 13, 2024 10:28
fixing an issue with preview layer being kept on the map after added through the catalogue component
@pakb pakb force-pushed the feat-PB-1204-cesium-wms-composable branch from 8543af7 to 23e2e5a Compare December 13, 2024 09:29
don't know why this pops up on this PR which doesn't change anything in the import KML, but I've added the necessary intercepts on the search made while importing a KML to fix the flakyness of this test.
Was certainly due to some race condition on the real search service responding faster than expected, we should not use the real service for such tests anyway...
@pakb pakb merged commit 6fbe6ad into develop Dec 13, 2024
6 checks passed
@pakb pakb deleted the feat-PB-1204-cesium-wms-composable branch December 13, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants