fixed deleting expired items that have pending asset uploads #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boecklic
force-pushed
the
fix_PB-1267_remove_exp_items
branch
2 times, most recently
from
18dfb6b to
352c3c0
Compare
boecklic
force-pushed
the
fix_PB-1267_remove_exp_items
branch
from
352c3c0 to
60d2423
Compare
schtibe
approved these changes
Dec 20, 2024
| def __init__(self, *args, **kwargs): | ||
|
|
||
| s3_bucket = kwargs.pop('s3_bucket', AVAILABLE_S3_BUCKETS.legacy) | ||
| print( |
There was a problem hiding this comment.
I think we ought to use self.print (though personally, I don't always trust that as it's doing some logging level stuff... in case of this command here, which I understand is supposed to be run manually, we always want the output, right?)
|
|
||
| def __init__(self, *args, **kwargs): | ||
|
|
||
| s3_bucket = kwargs.pop('s3_bucket', AVAILABLE_S3_BUCKETS.legacy) |
There was a problem hiding this comment.
So this seems as a preparation for chosing another bucket than legacy? I don't quite follow where this kwargs would be set, as there is no argument parse option
| self.print_success(f"Starting upload for {self.options['asset_id']}") | ||
| asset = Asset.objects.filter(name=self.options['asset_id']).first() | ||
|
|
||
| key = f"{asset.item.collection.name}/{asset.item.name}/{asset.name}" |
There was a problem hiding this comment.
FYI there's a function for that: def get_asset_path(item, asset_name): in utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.