Feature BGDIINF_SB-1814: get_id route implementation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltkum
requested review from
ltshb and
IsabelleBzr
and removed request for
IsabelleBzr
ltshb
requested changes
Jul 8, 2021
IsabelleBzr
reviewed
Jul 8, 2021
ltshb
reviewed
Jul 8, 2021
ltshb
reviewed
Jul 9, 2021
using the correct keys in the responses corrections to logs, making messages clearer, small correction to test to account for changes adding base test class for unit tests in routes added missing underscore removing unused field in json response
ltkum
force-pushed
the
feature_BGDIINF_SB-1814_fetch_id
branch
from
41a9256 to
66d78fa
Compare
ltshb
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : We want to have a route that gives us the ids of a given kml, in particular, which url leads to the kml when calling a given route
Fix :
implementation of the route
implementation of two unit tests