Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGDIINF_SB-2461: Added author_version information and made author field required - #major #64

Merged
merged 6 commits into from
Oct 25, 2022
Merged

BGDIINF_SB-2461: Added author_version information and made author field required - #major #64

merged 6 commits into from
Oct 25, 2022

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Oct 24, 2022 •
edited
Loading

@ltshb ltshb requested review from hansmannj and pakb October 24, 2022 14:25
hansmannj
hansmannj reviewed Oct 24, 2022
View reviewed changes
app/helpers/dynamodb.py Outdated Show resolved Hide resolved
hansmannj
hansmannj approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! 👍
I'd just suggest to add a short description of the DEFAULT_CLIENT_VERSION env var in the according table in README.md.

@ltshb ltshb force-pushed the feat-BGDIINF_SB-2461-new-column branch from f6ea170 to e8af6cd Compare October 25, 2022 09:30
@ltshb ltshb changed the title BGDIINF_SB-2461: Added client_version information. BGDIINF_SB-2461: Added author_version information and made author field required Oct 25, 2022
@ltshb ltshb requested a review from hansmannj October 25, 2022 09:54
@ltshb ltshb changed the title BGDIINF_SB-2461: Added author_version information and made author field required BGDIINF_SB-2461: Added author_version information and made author field required - #major Oct 25, 2022
ltshb added 2 commits October 25, 2022 13:06
@ltshb
BGDIINF_SB-2461: Made author field required - #major
28bee51 
This is a breaking changes as now the author field in POST is required.
@ltshb
Fixing make gunicorserve
14d4a30
@ltshb ltshb force-pushed the feat-BGDIINF_SB-2461-new-column branch from 9c93d22 to 14d4a30 Compare October 25, 2022 11:06
hansmannj
hansmannj approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍
Just a question: Do we use #major in PR title when merging a feature branch into develop and not developin master?

pakb
pakb approved these changes Oct 25, 2022
View reviewed changes
app/routes.py Show resolved Hide resolved
@ltshb
Copy link
Contributor Author

ltshb commented Oct 25, 2022

@hansmannj using #major here will tell the github action to create a major beta version instead of minor beta version, so it will generates a v2.0.0-beta.1 instead of a v1.6.0-beta.5. More importantly I added the #major in the commit message. So when we merge develop into master it will per default takes what it finds in commit message, this way I can avoid forgetting it later on.

@ltshb ltshb merged commit f4d4b84 into develop Oct 25, 2022
@ltshb ltshb deleted the feat-BGDIINF_SB-2461-new-column branch October 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

@hansmannj hansmannj hansmannj approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltshb @pakb @hansmannj