Update develop with hotfixes from master. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First Release
#major Release v1.0.0
New Release v1.1.0 - #minor
New Release v1.2.0 - #minor
New Release v1.2.1 - #patch
New Release v1.2.2 - #patch
New Release v1.3.0 - #minor
New Release - #patch
New Release v1.4.1 - #patch
New Release v1.5.0 - #minor
New Release v1.5.1 - #patch
In the case where the request is done from a subdomain the Origin header and the Sec-Fetch-Site headers were set. The later was however not set to 'same-origin' but 'same-site' because the origin is not equal but from a subdomain. Due to this the validation failed because we only allowed Sec-Fetch-Site==same-origin. This would also have been an issue if we would allow a cross site origin in the allowed domain, in this case the Sec-Fetch-Site would be 'cross-site'. So changed the validation logic to be clearer and correct. The validation is done only on the Origin header with a first fallback to Sec-Fetch-Site if Origin is not available and a last fallback to Referer header if the previous are not available.
…ation BGDIINF_SB-2420: Origin validation fixes - #patch
jedef
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.