Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIINF_SB-2346: Only check the kml file size and not the payload size #48

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

ltshb
Copy link
Contributor

@ltshb ltshb commented Apr 14, 2022

The payload size can change depending on the method POST or PUT and also
depending on the client that sets the mutlipart boundary string.

Therefore to avoid issue with kml file that might once be created and thereafter
not be edited anymore due to the overhead of the multipart payload we changed
the logic by checking the size of the file instead of the payload.

The payload size can change depending on the method POST or PUT and also
depending on the client that sets the mutlipart boundary string.

Therefore to avoid issue with kml file that might once be created and thereafter
not be edited anymore due to the overhead of the multipart payload we changed
the logic by checking the size of the file instead of the payload.
@github-actions github-actions bot added the bug label Apr 14, 2022
Copy link
Contributor

@boecklic boecklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch and fix!

@ltshb ltshb merged commit ebbda93 into develop Apr 20, 2022
@ltshb ltshb deleted the bug-BGDIINF_SB-2346-kml-size branch April 20, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants