Use SCRIPT_NAME instead of route prefix & configure gunicorn for secure scheme header
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
changed the title
ltshb
requested review from
boecklic,
hansmannj,
IsabelleBzr,
ltkum and
rebert
…secure scheme header The path prefix is now set by the deployment using the WSGI SCRIPT_NAME environment variable. Also configure gunicorn to use secure scheme header which allow us to get rid of the middleware. This settings is needed in order to set the correct http proto in generated urls in responses. Change the default ALLOWED_ORIGIN to allow everything.
ltshb
force-pushed
the
feature-route-prefix
branch
from
dae804b to
0954319
Compare
rebert
reviewed
Nov 3, 2021
| @@ -43,6 +43,7 @@ PIP_FILE_LOCK = Pipfile.lock | |||
| # default configuration | |||
| ENV_FILE ?= .env.default | |||
| HTTP_PORT ?= 5000 | |||
| ROUTE_PREFIX ?= /api/kml | |||
There was a problem hiding this comment.
WHY not using SCRIPT_NAME allover?
There was a problem hiding this comment.
@rebert What do you mean exactly ? We cannot use the SCRIPT_NAME with the Flask development server, only with gunicorn.
IsabelleBzr
approved these changes
Nov 3, 2021
README.md
Outdated
Comment on lines
33
to
34
| | DEV | [https://sys-publid.dev.bgdi.ch/api/kml/](https://sys-publid.dev.bgdi.ch/api/kml/) | | ||
| | INT | [https://sys-publid.int.bgdi.ch/api/kml/](https://sys-publid.int.bgdi.ch/api/kml/) | |
There was a problem hiding this comment.
Small typing error, public
ltshb
changed the title
SCRIPT_NAME instead of route prefix & configure gunicorn for secure scheme header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path prefix is now set by the deployment using the WSGI SCRIPT_NAME
environment variable. The change in this paradigma come from this post: https://dlukes.github.io/flask-wsgi-url-prefix.html
Also configure gunicorn to use secure scheme header which allow us to
get rid of the middleware. This settings is required in order to have the correct proto in generated urls in responses.
Change the default ALLOWED_ORIGIN to allow everything.