BGDIINF_SB-1971: Addaptation to new spec from doc-api-spec #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltshb
force-pushed
the
feature_BGDIINF_SB-1971_new_spec
branch
2 times, most recently
from
33115d5 to
1ac4016
Compare
This implement the new kml spec based on geoadmin/doc-api-spec - POST api/kml/admin multipart/form-data kml=<kml-file> - GET api/kml/admin/<kml_id> - PUT api/kml/admin/<kml_id> mutlipart/form-data admin_id=<admin_id> kml=<kml-file> - DEL api/kml/admin/<kml_id> multipart/form-data admin_id=<admin_id>
ltshb
force-pushed
the
feature_BGDIINF_SB-1971_new_spec
branch
from
1ac4016 to
571edce
Compare
ltshb
requested review from
hansmannj,
ltkum,
IsabelleBzr and
boecklic
and removed request for
ltkum
Now the S3 file returns the correct content-type
|
Nice revamping of the validations and few new test cases added, thanks! 👍 |
hansmannj
approved these changes
Sep 15, 2021
| db.update_item_timestamp(kml_admin_id, timestamp) | ||
| item = db.get_item(kml_admin_id) | ||
| timestamp = datetime.utcnow().replace(tzinfo=timezone.utc).isoformat() | ||
| db.update_item(kml_id, timestamp, empty) |
There was a problem hiding this comment.
Does it make sense to update an existing kml, in case it is to be replaced with an empty kml string? Isn't this rather a deletion then?
| return inner_decorator | ||
|
|
||
|
|
||
| def validate_kml_string(kml_string): |
There was a problem hiding this comment.
Nice additions to the validations!
| response = self.app.put( | ||
| url_for('update_kml', kml_id=id_to_put), | ||
| data=prepare_kml_payload(self.kml_dict["updated"]), | ||
| content_type="multipart/form-data", |
There was a problem hiding this comment.
Should be "Permission denied" in line 221 for consistency (line 221 not part of this PR)
There was a problem hiding this comment.
I changed every where to 403 Permission denied
hansmannj
reviewed
Sep 15, 2021
tests/unit_tests/test_routes.py
Outdated
| ) | ||
| self.assertEqual(response.status_code, 403) | ||
| self.assertEqual(response.content_type, "application/json") | ||
| self.assertEqual(response.json["error"]["message"], "Not allowed") |
There was a problem hiding this comment.
Picky, I know: Later on you use "Permission denied" for non allowed admin_id operations. (just for consistency)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See new spec in https://github.com/geoadmin/doc-api-specs/pull/12