BGDIINF_SB-2461: Removed useless default parameters

geoadmin · Oct 25, 2022 · 58eff4d · 58eff4d
1 parent 14d4a30
commit 58eff4d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/app/helpers/dynamodb.py b/app/helpers/dynamodb.py
@@ -13,7 +13,6 @@
 from app.settings import AWS_DB_REGION_NAME
 from app.settings import AWS_DB_TABLE_NAME
 from app.settings import AWS_S3_BUCKET_NAME
-from app.settings import DEFAULT_AUTHOR_VERSION
 from app.settings import KML_FILE_CONTENT_ENCODING
 from app.settings import KML_FILE_CONTENT_TYPE
 
@@ -44,15 +43,7 @@ def __init__(self, table_name, bucket_name, endpoint_url, table_region):
         self.endpoint = endpoint_url
 
     def save_item(
-        self,
-        kml_id,
-        kml_admin_id,
-        file_key,
-        file_length,
-        timestamp,
-        empty=False,
-        author='',
-        author_version=DEFAULT_AUTHOR_VERSION
+        self, kml_id, kml_admin_id, file_key, file_length, timestamp, author, author_version, empty
     ):
         logger.debug('Saving dynamodb item with primary key %s', kml_id)
         db_item = {

diff --git a/app/routes.py b/app/routes.py
@@ -59,9 +59,9 @@ def create_kml():
         file_key,
         len(kml_string_gzip),
         timestamp,
-        empty,
         author,
-        author_version
+        author_version,
+        empty
     )
 
     return make_response(jsonify(get_json_metadata(db_item, with_admin_id=True)), 201)