-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Release v1.5.1 - #patch #92
Conversation
… 'babs-v2-{LANG}'
…le-lint requirements
…following PR review. -renamed all occurrences of true/false to True/False
PB-1083: Add simple versioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort and the quick implementation of the changes @sami-nouidri-swisstopo
Not sure, if it really is to be considered a breaking change though.
We simply changed the name of an existing icon set, which has not yet been productive so far.
So IMHO this is just a #patch. Especially since from the user's perspective so far the new icon sets are unlisted (only visible on DEV), hence any changes are more or less transparent.
But we can address this quickly in today's refinement.
I've amended the change after discussing it again with @pakb |
The deployment on DEV has been done and tested successfully. As such, I want to merge develop into master to conduct integration tests with the map viewer.
̶A̶f̶t̶e̶r̶ ̶d̶i̶s̶c̶u̶s̶s̶i̶n̶g̶ ̶t̶h̶e̶ ̶m̶a̶t̶t̶e̶r̶ ̶w̶i̶t̶h̶ ̶@̶p̶a̶k̶b̶,̶ ̶t̶h̶e̶s̶e̶ ̶c̶h̶a̶n̶g̶e̶s̶ ̶t̶o̶ ̶i̶c̶o̶n̶ ̶p̶a̶t̶h̶s̶ ̶h̶a̶v̶e̶ ̶b̶e̶e̶n̶ ̶d̶e̶e̶m̶e̶d̶ ̶"̶b̶r̶e̶a̶k̶i̶n̶g̶"̶ ̶a̶n̶d̶ ̶t̶h̶e̶r̶e̶f̶o̶r̶e̶ ̶w̶a̶r̶r̶a̶n̶t̶ ̶a̶ ̶m̶a̶j̶o̶r̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶c̶h̶a̶n̶g̶e̶.̶ ̶
Following comments from @hansmannj and discussion with @pakb, we'll stick with a patch incrementation instead.