Update milestone branch with hotfix from master #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API we use to get time table data for open transport stops will be decomissioned soon. Hence we migrate to OJP 2.0. The requests to the API and the parsing of the response needed some adaptions for that. Furthermore, the OJP 2.0 API's response sometimes has a strange timestamp format, there are sometimes 7 instead of the expexted 6 digits for the milliseconds. Hence a try except was used to safely convert to the expected format in that cases. Also some minor code clean-up was done.
…eleted superfluous comments
Originally there were separate test files for opentransapi and the stationboard. This is now again the case, also several test cases got lost, which were re-added again. Also added dependencies in order to fix TypeError: __init__() got an unexpected keyword argument 'management'
…as_to_ojp_for_transport_stop_requests PB-974: Migration from trias to ojp for transport stop requests
hansmannj
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.