Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-130: As announced, api3 is not accepting HTTP PUT, POST and DELETE… #4350

Merged
merged 1 commit into from
Mar 11, 2024
Merged

PB-130: As announced, api3 is not accepting HTTP PUT, POST and DELETE… #4350

merged 1 commit into from
Mar 11, 2024

Conversation

rebert
Copy link
Contributor

@rebert rebert commented Mar 6, 2024

… anymore

@rebert rebert requested review from procrastinatio and ltshb March 6, 2024 15:08
@github-actions github-actions bot added this to the 2024-03-13 milestone Mar 6, 2024
@rebert rebert requested review from boecklic and hansmannj March 6, 2024 15:09
@rebert rebert force-pushed the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch from 0f4f6ce to e76eeee Compare March 6, 2024 15:11
@rebert rebert marked this pull request as draft March 6, 2024 15:31
@rebert rebert assigned rebert and unassigned rebert Mar 6, 2024
@rebert rebert marked this pull request as ready for review March 6, 2024 15:36
@rebert rebert force-pushed the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch 2 times, most recently from 1275cd0 to df1052c Compare March 6, 2024 16:19
@rebert rebert marked this pull request as draft March 7, 2024 08:40
@rebert rebert force-pushed the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch 2 times, most recently from 45a375c to 6af6fa5 Compare March 7, 2024 13:33
@rebert rebert marked this pull request as ready for review March 7, 2024 15:56
@rebert rebert force-pushed the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch 3 times, most recently from 1bbc23e to 84087e8 Compare March 8, 2024 10:05
@rebert rebert requested review from ltflb-bgdi and removed request for procrastinatio March 8, 2024 10:08
@rebert rebert force-pushed the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch 3 times, most recently from 547ed64 to f7ef8f1 Compare March 8, 2024 10:14
@rebert
PB-130: As announced, api3 is not accepting HTTP PUT, POST and DELETE…
2733091 
… anymore

- Accepting GET, HEAD, OPTIONS

- Returning empty string when OPTIONS is set
@rebert rebert force-pushed the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch from f7ef8f1 to 2733091 Compare March 8, 2024 10:24
boecklic
boecklic approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@boecklic boecklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hansmannj
hansmannj approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@hansmannj hansmannj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks!

@rebert rebert merged commit c940f57 into develop-2024-03-13 Mar 11, 2024
5 checks passed
@rebert rebert deleted the feat-PB-130-not-accepting-http-PUT-POST-DELETE-anymore branch March 11, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltshb ltshb ltshb approved these changes

@hansmannj hansmannj hansmannj approved these changes

@boecklic boecklic boecklic approved these changes

@ltflb-bgdi ltflb-bgdi Awaiting requested review from ltflb-bgdi

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
2024-03-13
Development

Successfully merging this pull request may close these issues.
4 participants
@rebert @boecklic @hansmannj @ltshb