Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGDIDIC-1347: delete model and mako #4281

Merged
merged 3 commits into from
Nov 6, 2023
Merged

BGDIDIC-1347: delete model and mako #4281

merged 3 commits into from
Nov 6, 2023

Conversation

faselm
Copy link
Contributor

@faselm faselm commented Nov 2, 2023

No description provided.

@faselm faselm requested review from marionb, rebert and ltclm November 2, 2023 15:45
@github-actions github-actions bot added this to the 2023-12-20 milestone Nov 2, 2023
ltclm
ltclm requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the legends too.
and please run make lint to fix the tests.

@faselm faselm requested a review from ltclm November 6, 2023 08:31
@faselm
Copy link
Contributor Author

faselm commented Nov 6, 2023

Hi @ltclm, it should be good now

@faselm faselm merged commit 1256346 into develop-2023-12-20 Nov 6, 2023
4 checks passed
@faselm faselm deleted the feat-BGDIDIC-1347-decomm-pronatura-waldreservate branch November 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltclm ltclm ltclm approved these changes

@marionb marionb Awaiting requested review from marionb

@rebert rebert Awaiting requested review from rebert

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
2023-12-20
Development

Successfully merging this pull request may close these issues.
2 participants
@faselm @ltclm