Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIDIC-1296 update legend png #4277

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

marionb
Copy link
Contributor

@marionb marionb commented Oct 26, 2023

No description provided.

@marionb marionb self-assigned this Oct 26, 2023
@github-actions github-actions bot added this to the 2023-11-01 milestone Oct 26, 2023
@github-actions github-actions bot added the data-integration This issue/pr is related to data integration work label Oct 26, 2023
@marionb marionb force-pushed the data_BGDIDIC-1296_update_legend branch from 2e08a71 to 4b8588c Compare October 26, 2023 12:11
@marionb marionb requested review from rebert, ltclm and faselm October 26, 2023 12:12
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have the limitation that png legends in the legend response should not be wider than 480px:

https://api3.geo.admin.ch/rest/services/all/MapServer/ch.bazl.segelflugkarte/legend?lang=de

If it is necessary to create more detailed legends, you have to create a thumbnail png with max 480px and a _big.pdf for each language with the detailed view.

p.e. ch.bazl.segelflugkarte
you also have to add this layer to this static list:
https://github.com/geoadmin/mf-chsdi3/blob/develop-2023-11-01/chsdi/templates/legend.mako#L8

@marionb
Copy link
Contributor Author

marionb commented Oct 26, 2023

@ltclm thanks for the hint. A simple resize of the image should do :-)

@marionb marionb requested a review from ltclm October 26, 2023 13:37
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you

@marionb marionb marked this pull request as ready for review October 26, 2023 13:44
@marionb marionb force-pushed the data_BGDIDIC-1296_update_legend branch from 2286c8b to ca120ae Compare October 26, 2023 13:45
@marionb marionb merged commit 32f77b0 into develop-2023-11-01 Oct 26, 2023
4 checks passed
@marionb marionb deleted the data_BGDIDIC-1296_update_legend branch October 26, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-integration This issue/pr is related to data integration work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants