Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGDIDIC-1256: add field gwr_egid #4268

Merged
merged 1 commit into from
Oct 9, 2023
Merged

BGDIDIC-1256: add field gwr_egid #4268

merged 1 commit into from
Oct 9, 2023

Conversation

faselm
Copy link
Contributor

@faselm faselm commented Sep 25, 2023

No description provided.

@github-actions github-actions bot added this to the 2023-11-01 milestone Sep 25, 2023
@faselm faselm requested review from marionb, rebert and ltclm September 25, 2023 09:05
ltclm
ltclm requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but can you please ask if htmlpopup is really not needed?

@faselm
Copy link
Contributor Author

faselm commented Oct 9, 2023

Hi @ltclm, no, htmlpopup is not needed

@faselm faselm requested a review from ltclm October 9, 2023 09:16
@faselm faselm merged commit 7391606 into develop-2023-11-01 Oct 9, 2023
@faselm faselm deleted the feat-BGDIDIC-1256-solarenergie-eignung branch October 9, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltclm ltclm ltclm approved these changes

@marionb marionb Awaiting requested review from marionb

@rebert rebert Awaiting requested review from rebert

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
2023-11-01
Development

Successfully merging this pull request may close these issues.
2 participants
@faselm @ltclm