Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat bgdidic 2643 fauna wildtierpassagen #4248

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

faselm
Copy link
Contributor

@faselm faselm commented Aug 29, 2023

No description provided.

@github-actions github-actions bot added this to the 2023-09-06 milestone Aug 29, 2023
@faselm faselm removed this from the 2023-09-06 milestone Aug 29, 2023
@faselm faselm marked this pull request as draft August 29, 2023 09:15
@github-actions github-actions bot added this to the 2023-09-06 milestone Aug 29, 2023
@faselm faselm removed this from the 2023-09-06 milestone Aug 29, 2023
@ltclm ltclm changed the base branch from develop-2023-09-06 to master September 4, 2023 14:31
@faselm faselm added this to the 2023-11-01 milestone Sep 6, 2023
@faselm faselm force-pushed the feat-BGDIDIC-2643-fauna-wildtierpassagen branch from 259e814 to 88d2c3b Compare September 6, 2023 09:39
@github-actions github-actions bot removed this from the 2023-11-01 milestone Sep 6, 2023
@faselm faselm added this to the 2023-11-01 milestone Sep 6, 2023
@faselm faselm changed the base branch from master to develop-2023-11-01 September 6, 2023 09:39
@faselm faselm marked this pull request as ready for review September 6, 2023 13:25
@faselm faselm requested review from marionb, rebert and ltclm September 6, 2023 13:30
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just wondering why the attribute bauwerkstyp_... are not used in the htmlpopup

@faselm
Copy link
Contributor Author

faselm commented Sep 6, 2023

@ltclm yes, thanks, the field was removed by the data provider after the "first version". I've just removed it

@faselm faselm merged commit 31dc1e0 into develop-2023-11-01 Sep 6, 2023
@faselm faselm deleted the feat-BGDIDIC-2643-fauna-wildtierpassagen branch September 6, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants