Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIDIC-1905: remove raster tooltip #4165

Merged

Conversation

faselm
Copy link
Contributor

@faselm faselm commented Mar 27, 2023

No description provided.

@github-actions github-actions bot added this to the 2023-05-10 milestone Mar 27, 2023
@faselm faselm requested review from ltclm, marionb and rebert March 27, 2023 15:28
Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gridId 2 and 3 are not used anymore with this pr, please remove their grid definition too.

please check the bod too, probably you have to disable some tooltip flags there too.

@faselm faselm requested a review from ltclm March 28, 2023 06:14
Copy link
Contributor

@rebert rebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @faselm

Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the failing tests first:

[Container] 2023/03/28 06:19:54 Running command make lint
--
224 | Linting python files...
225 | /root/.local/share/virtualenvs/mf-chsdi3-7uDe9lBo/bin/flake8 --ignore="E128,E221,E241,E251,E272,E305,E501,E711,E731,W503,W504,W605" chsdi/__init__.py chsdi/lib/__init__.py chsdi/lib/exceptions.py chsdi/lib/filters.py chsdi/lib/helpers.py chsdi/lib/opentransapi/__init__.py chsdi/lib/opentransapi/opentransapi.py chsdi/lib/parser.py chsdi/lib/sqlalchemy_customs.py chsdi/lib/validation/__init__.py chsdi/lib/validation/features.py chsdi/lib/validation/find.py chsdi/lib/validation/identify.py chsdi/logging_setup.py chsdi/logging_tweens.py chsdi/models/__init__.py chsdi/models/bod.py chsdi/models/grid/__init__.py chsdi/models/s3_client.py chsdi/models/types.py chsdi/models/vector/__init__.py chsdi/models/vector/are.py chsdi/models/vector/bafu.py chsdi/models/vector/bak.py chsdi/models/vector/diemo.py chsdi/models/vector/dritte.py chsdi/models/vector/edi.py chsdi/models/vector/evd.py chsdi/models/vector/kogis.py chsdi/models/vector/lubis.py chsdi/models/vector/oereb/__init__.py chsdi/models/vector/oereb/uvek.py chsdi/models/vector/oereb/vbs.py chsdi/models/vector/stopo.py chsdi/models/vector/uvek.py chsdi/models/vector/uvek_solarkataster.py chsdi/models/vector/vbs.py chsdi/models/vector/zeitreihen.py chsdi/renderers.py chsdi/response_callbacks.py chsdi/subscribers.py chsdi/views/__init__.py chsdi/views/catalog.py chsdi/views/checker.py chsdi/views/color.py chsdi/views/features.py chsdi/views/historicalmaps.py chsdi/views/httpexception_json.py chsdi/views/layers.py chsdi/views/loader.py chsdi/views/luftbilder.py chsdi/views/stationboard.py chsdi/views/topics.py chsdi/views/translations.py tests/__init__.py tests/functional/__init__.py tests/functional/test_catalog_tree.py tests/functional/test_helpers.py tests/functional/test_parser.py tests/functional/test_renderer.py tests/functional/test_types.py tests/functional/test_vector.py tests/integration/__init__.py tests/integration/test_cache_update.py tests/integration/test_catalog.py tests/integration/test_checker.py tests/integration/test_color.py tests/integration/test_doc.py tests/integration/test_features_service.py tests/integration/test_historicalmaps.py tests/integration/test_identify_service.py tests/integration/test_layers_service.py tests/integration/test_loader.py tests/integration/test_luftbilder.py tests/integration/test_opentransapi.py tests/integration/test_rss.py tests/integration/test_stationboard.py tests/integration/test_topics.py tests/integration/test_translation.py && echo
226 | chsdi/models/grid/__init__.py:49:1: W391 blank line at end of file
227 | make: *** [Makefile:396: lint] Error 1


@faselm faselm requested a review from ltclm March 28, 2023 07:20
@faselm faselm merged commit 4e2ec05 into develop-2023-05-10 Mar 28, 2023
@faselm faselm deleted the feat-BGDIDIC-1905-gewaesserschutz-diffuse_eintraege branch March 28, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants