Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGDIDIC-1789: Rounding coordinates and alti to .3f #4151

Merged

Conversation

rebert
Copy link
Contributor

@rebert rebert commented Mar 9, 2023

  • The datenherr wishes to have the coordinates rounded on .3f

    This will only be visible in the tooltip. The data and the model

    are currently holding the easting and northing together as a string

@rebert rebert requested a review from faselm March 9, 2023 07:57
@github-actions github-actions bot added this to the 2023-03-15 milestone Mar 9, 2023
- The datenherr wishes to have the coordinates rounded on .3f

  This will only be visible in the tooltip. The data and the model

  are currently holding the easting and northing together as a string
@rebert rebert force-pushed the feat-BGDIDIC-1789-round-coord-and-alti-fp2 branch from 7a7af7f to 3c3ae34 Compare March 9, 2023 07:58
@rebert rebert requested review from marionb and procrastinatio March 9, 2023 07:58
Copy link
Contributor

@marionb marionb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM thanks!

@@ -9,13 +9,27 @@
return value if c['layerBodId'] in result else result
%>
</%def>
<%def name="fengshui_coord(coord)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting name 👍

@rebert rebert merged commit b58404b into develop-2023-03-15 Mar 9, 2023
@rebert rebert deleted the feat-BGDIDIC-1789-round-coord-and-alti-fp2 branch March 9, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants