Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 6.0.x sup 15720 #134

Open
wants to merge 4 commits into
base: hotfix-6.0.x
Choose a base branch
from
Open

Conversation

bogdandavydov
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bogdandavydov
❌ Bogdan Davydov


Bogdan Davydov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ yrucrem
✅ deckdom
❌ GenticsDev
❌ Bogdan Davydov


Bogdan Davydov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@npomaroli
Copy link
Member

The Merge Request needs to be directed to branch hotfix-6.0.x, not master.

@bogdandavydov bogdandavydov changed the base branch from master to hotfix-6.0.x September 4, 2023 14:50
@bogdandavydov
Copy link
Author

Changed it

Copy link
Member

@npomaroli npomaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry explaining the change (to our customers).

@bogdandavydov
Copy link
Author

I fixed the problems, pls review

Copy link
Member

@npomaroli npomaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still no changelog entry.

@bogdandavydov
Copy link
Author

@npomaroli, i deleted bladeTemplateName property, we really don't need it.

@bogdandavydov
Copy link
Author

Added changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants