Fixed bug in functionSubstitute

[neworderofjamie]

If you made a mistake in a code string where you didn't close a bracket on a function substitution e.g.

"$(for_each_synapse, printf(\"%d,\", $(id_post))"

The functionSubstitute function previously got stuck in an infinite loop. This fixes that issue and adds a couple of unit tests.

[codecov]

Codecov Report

Base: 88.80% // Head: 88.80% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (542934b) compared to base (0312dc5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files          76       76           
  Lines       12344    12345    +1     
=======================================
+ Hits        10962    10963    +1     
  Misses       1382     1382           

Impacted Files	Coverage Δ
src/genn/genn/code_generator/codeGenUtils.cc	89.75% <100.00%> (+0.05%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[tnowotny]

Looks like we are going more and more into the parser rabbit hole but that was to be expected...

[neworderofjamie]

Yeah, although these adhoc parsers will all be replaced with the parser once I integrate it which should be more maintainable