Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect WSL when linking CUDA and add additional wsl linker path #500

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

neworderofjamie
Copy link
Contributor

@neworderofjamie neworderofjamie commented Feb 4, 2022

I've been playing with the updated version of Windows Subsystem for Linux which provides support for CUDA (and x-forwarding) in the Linux image. Because GeNN links to the CUDA driver as well as the runtime, a small change is required as the CUDA driver is in a weird location (essentially it's mounted from the Windows driver installation)

Overall, it seems to perform pretty well - only a marginal increase in overhead compared to running natively on Windows

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #500 (c932a42) into master (acad848) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   87.04%   87.03%   -0.01%     
==========================================
  Files          84       84              
  Lines       18104    18104              
==========================================
- Hits        15758    15757       -1     
- Misses       2346     2347       +1     
Impacted Files Coverage Δ
src/genn/backends/cuda/optimiser.cc 72.77% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acad848...c932a42. Read the comment docs.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that looks fine I think.

@neworderofjamie neworderofjamie merged commit 01d1bca into master Feb 11, 2022
neworderofjamie added a commit that referenced this pull request Feb 11, 2022
Detect WSL when linking CUDA and add additional wsl linker path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants