Include model name in DLL name on Windows #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the inflexibility of Windows DLLfinding,
runner_Release.dll
(orrunner_Debug.dll
) is created in the same directory as the script (rather than in the***_CODE
sub-directory with everything else). Previously this was only a minor annoyance but, now the caching system (#430) means that models don't always get rebuilt, it can lead to an issue where, if you have multiple models in one directory, a DLL for the wrong model will get loaded.This PR solves this by adding a flag which includes the model name in the DLL name (for backward compatibility, for now, this is not the default). In PyGeNN, as we're in control of both building and loading the DLL, this is now the default.