Fixes nasty bug when locale means , is used for decimal point #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than ``std::string`` both because it's correct and, specifically, because it ignores locales
tnowotny
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea how no one has encountered this before but, turns out, as well as truncating floating point point numbers,
std::to_stringalso formats them according to the current locale which may include using "," as a decimal point, leading to constants which the compiler doesn't understand.ModelSpec::scalarExpris the one place wherestd::to_stringis used for printing floating point so simple fix was to change this to useUtils::writePreciseString(I also fixed a warning in the tests)