Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional input arguments to vc-gatk4-hc #1403

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marcellevstek
Copy link
Contributor

@marcellevstek marcellevstek commented Dec 5, 2024

REID-2669

  • Update CHANGELOG.rst for each commit separately:
    • Pay attention to write entries under the "Unreleased" section.
    • Mark all breaking changes as "BACKWARD INCOMPATIBLE:" and put them
      before non-breaking changes.
    • If a commit modifies a feature listed under "Unreleased" section,
      it might be sufficient to modify the existing CHANGELOG entry from previous
      commit(s).
  • Bump the process version:
    • MAJOR version (first number): Backward incompatible changes (changes
      that break the api/interface). Examples: renaming the input/output, adding
      mandatory input, removing input/output...
    • MINOR version (middle number): add functionality or changes in a
      backwards-compatible manner. Examples: add output field, add non-mandatory
      input parameter, use a different tool that produces same results...
    • PATCH version (last number): changes/bug fixes that do not affect
      the api/interface. Examples: typo fix, change/add warning messages...
  • All inputs are used in process.
  • All output fields have a value assigned to them.

@marcellevstek
Copy link
Contributor Author

@jkokosar I did not check the output BAM in IGV, as I assume the tools outputs it correctly.

Here is the documentation for the version we are using:
https://gatk.broadinstitute.org/hc/en-us/articles/4414586765723-HaplotypeCaller

Copy link
Member

@jkokosar jkokosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if the output BAM file is position sorted. Add index file to the separate output field.

@marcellevstek marcellevstek changed the title Add BAM output option to vc-gatk4-hc Add additional input arguments to vc-gatk4-hc Dec 10, 2024
Copy link
Member

@jkokosar jkokosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants