-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with the Laravel Exception Handler #25
base: master
Are you sure you want to change the base?
Conversation
Usage: return (new Healthz([$env, $debugCheck, $db])) ->setReportFailure(true)->setReportWarning(true); Reference: https://laravel.com/docs/8.x/errors
@tortuetorche I do think this a valuable addition. Would you mind adding some tests around these new methods? |
Done ✅ Build passing on my repository: https://app.travis-ci.com/github/tortuetorche/php-healthz/builds/231665384 |
Hi @Olofguard, Is is OK for you? Have a good day, |
Hi @Olofguard, This pull request is now ready for review 🕵️ then for merge 🚀! Have a good day, |
Hi @Olofguard, Any news on reviewing this pull request? Have a good week, |
@tortuetorche this looks like a great addition. 👍 I'm also using external services like Sentry so this will be helpful. @Olofguard would you mind checking this again? Thank you. |
Yup I’ll try to prioritize this tomorrow. Apologies for the delay, our team over here has shrunk significantly. |
@Olofguard A gentle follow-up regarding this one. Thank you. |
If the
report()
Laravel helper is present, otherwise do nothing.This feature is disabled by default, here how to enable it for Healthz failure and warning exceptions:
Then it can report Healthz failure and warning exceptions to the Laravel log exceptions or send them to an external service like Flare, Bugsnag or Sentry.
Reference: https://laravel.com/docs/8.x/errors