-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get feedback on current gorefs.yaml
format and update if needed
#2232
Comments
I have two comments. First is that most of the other metadata YAML files seem to be structured as an array at the top-level, such as: - id: one
- id: two
- id: three Whereas the current structure of gorefs:
- id: one
- id: two
- id: three This is probably influenced by the fact that LinkML implicitly encourages this kind of modelling, but recent changes to LinkML validation means it's not strictly required. If we want a top-level array that's fine. Second is that I don't think the @kltm who else might have input here? |
@pgaudet Could have some input here (and is PO), but I think this is likely a more technical detail. I'll try and touch bases with her tomorrow morning. Sans input, I would go ahead with the most "natural" LinkML possible. |
Hi @pkalita-lbl It seems like some of these yaml schemas were copied/pasted and not always contain strictly relevant items, some fields do seem superfluous. Let me know if you want to go over this on a call, it may be easier for all of us (and also to write up some doc, if needed). Thanks, Pascale |
gorefs.yaml
format and udpate if neededgorefs.yaml
format and update if needed
Nope! That's just part of GitHub's Markdown rendering. And just in case the big picture wasn't clear from all the granular issues: the end result will be that these Markdown files won't exist at all anymore, replaced by generated pages hosted on geneontology.org.
That's definitely my impression, too! Since it seems like there aren't extremely strong opinions on this, I'll take a crack at doing the simplifications already mentioned. Once there's something to look at maybe we can find a venue for the three of us (plus anyone else who might be interested) to review it. |
I don't need to review necessarily but just keep me in the loop if anything on the geneontology.org changes. FYI the menus and headers on geneontology.org will be changing in the near future so "just place it anywhere" is a valid location for now as long as I know about any new pages I need to rehome. |
@pgaudet @kltm @suzialeksander Here is a proposal for the format of https://gist.github.com/pkalita-lbl/4551e15e90407ad1f514a6f854fd26b5 Some fields to note:
All of the fields from the Markdown frontmatter section ( Does this look like a format you'd be comfortable working with when we deprecate the Markdown files? |
Hi @pkalita-lbl |
They can be if that is what's desired. Or they can be separate pages. Those options aren't necessarily mutually exclusive; both individual pages and an index page could exist. But that's all sort of orthogonal to the task of this issue. The details of the generated page(s) will be worked out in geneontology/geneontology.github.io#506. |
Talking to @pkalita-lbl on #2232 (comment) , we'll go ahead with his schema. |
Review the format of the current
gorefs.yaml
file. If changes are desired, then use this issue to also:The text was updated successfully, but these errors were encountered: