Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses
pymonad
to build a MonadDict from RDF queries. I assume this will mean thatLookupErrors
won't happen since we'll getNothing
in this case.How
MonadDict
constructor cannot handle this since it assumes the input dictionary won't be nested. I've added an extra function that will recursively buildMonadDicts
when any key, value pairs point to a dictionary or a list.bind
andmap
to ensure thatJust(x)
andNothing
are handled okTesting
The script seems to run ok locally:
Caveats That I'll Try to Fix
mypy
fails when I run it against this branch. Here's what I see:It seems like
mypy
can't infer the subtypes for the various monaddicts.