Feature/pass sample vals as json #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s JSON instead of having separate form parameters for each sample + removed some commented out code/logging
… sample values (pulled from the sample table using DataTables API in show_trait.js)
…is included in start_vars when trait page parameters are passed to the mapping loading page
…ad of separate ones for every sample + added sample_vals to the list of inputs sent to the loading page
…ad of a bunch of separate input parameters
…m the JSON sample_vals parameter
… sample_vals parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way sample values are passed to mapping and correlation tools from the trait page. Currently there's a separate parameter for every single sample, which is pretty dumb. This instead makes a single parameter that contains JSON of all the sample values.
This probably also isn't ideal (since it still includes all the samples in the form), but it's definitely preferable to the way it currently is.
How should this be tested?
Do anything involving correlations or mapping from the trait page (or zooming into regions or reloading mapping results) with any sort of trait. Things should work as expected, and any problems will likely manifest as an error. One other thing to look out for is the N being wrong on the loading page (I think this issue is fixed, but worth keeping an eye on to make sure the number of values being passed is correct).
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
N/A
Screenshots (if appropriate)
Questions