Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beet completion crashes with lastest git #38

Closed
arlllk opened this issue Sep 13, 2019 · 1 comment · Fixed by #39
Closed

beet completion crashes with lastest git #38

arlllk opened this issue Sep 13, 2019 · 1 comment · Fixed by #39

Comments

@arlllk
Copy link

arlllk commented Sep 13, 2019

When trying to run beet completion with the latest git of beets and beets-alternatives

beets-alternatives 0.10.0.r0.g5751eb7

beets version 1.5.0
Python version 3.7.4
plugins: absubmit, acousticbrainz, alternatives, artistcountry, badfiles, beatport, chroma, convert, discogs, duplicates, edit, embedart, export, fetchart, filefilter, fromfilename, ftintitle, fuzzy, hook, ihate, importfeeds, info, lastimport, lyrics, mbsubmit, mbsync, metasync, missing, playlist, random, replaygain, rewrite, smartplaylist, thumbnails, web

fails with

Traceback (most recent call last):
  File "/usr/bin/beet", line 11, in <module>
    load_entry_point('beets==1.5.0', 'console_scripts', 'beet')()
  File "/usr/lib/python3.7/site-packages/beets/ui/__init__.py", line 1267, in main
    _raw_main(args)
  File "/usr/lib/python3.7/site-packages/beets/ui/__init__.py", line 1254, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/usr/lib/python3.7/site-packages/beets/ui/commands.py", line 1707, in print_completion
    for line in completion_script(default_commands + plugins.commands()):
  File "/usr/lib/python3.7/site-packages/beets/ui/commands.py", line 1748, in completion_script
    for opts in cmd.parser._get_all_options()[1:]:
AttributeError: 'ArgumentParser' object has no attribute '_get_all_options'

full output

geigerzaehler pushed a commit that referenced this issue Sep 15, 2019
Add the `_get_all_options()` method to the argument parser so that `beet
completion` does not throw an error anymore.

Fixes #38
geigerzaehler pushed a commit that referenced this issue Sep 15, 2019
Add the `_get_all_options()` method to the argument parser so that `beet
completion` does not throw an error anymore.

Fixes #38
@geigerzaehler
Copy link
Owner

Thanks for the report @arlllk. I prepared a fix in #39. As soon as that PR is reviewed and merged I will release a new version.

geigerzaehler pushed a commit that referenced this issue Sep 15, 2019
Add the `_get_all_options()` method to the argument parser so that `beet
completion` does not throw an error anymore.

Fixes #38
geigerzaehler pushed a commit that referenced this issue Sep 18, 2019
Add the `_get_all_options()` method to the argument parser so that `beet
completion` does not throw an error anymore.

Fixes #38
geigerzaehler pushed a commit that referenced this issue Sep 18, 2019
Changelog

* Running `beet completion` does not crash anymore [#38][]

[#38]: #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants