Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-16 - Remove cargo core usage: #138

Merged

Conversation

jmcconnell26
Copy link
Contributor

  • Remove cargo core usage from scan module
  • Remove cargo core usage from traversal module
  • Remove cargo core usage from format module
  • Remove cargo core usage from scan module
  • Refactor krates_utils into separate modules

Signed-off-by: joshmc [email protected]

@jmcconnell26 jmcconnell26 force-pushed the ISSUE-16-RemoveCargoCoreUsageFromScan branch from 075fe5f to 1640619 Compare November 12, 2020 18:31
@jmcconnell26
Copy link
Contributor Author

Working through pulling out more of the cargo::core usage + a small refactoring of the krates_utils into sub modules.

@jmcconnell26 jmcconnell26 force-pushed the ISSUE-16-RemoveCargoCoreUsageFromScan branch 2 times, most recently from 921b096 to 04f2b2d Compare November 12, 2020 19:56
* Remove cargo core usage from scan module
* Remove cargo core usage from traversal module
* Remove cargo core usage from format module
* Remove cargo core usage from scan module
* Refactor krates_utils into separate modules
* Update tarpaulin version xd009642/tarpaulin#517

Signed-off-by: joshmc <[email protected]>
@jmcconnell26 jmcconnell26 force-pushed the ISSUE-16-RemoveCargoCoreUsageFromScan branch from 04f2b2d to 5f8322b Compare November 12, 2020 20:22
Copy link
Contributor

@anderejd anderejd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting up the krates_utils module looks great.

cargo-geiger/src/format/display.rs Outdated Show resolved Hide resolved
cargo-geiger/src/scan/forbid/table.rs Outdated Show resolved Hide resolved
* Updating usages of `krates::Builder` to KratesBuilder
* Removing commented out code
* Making requested changes from a later version of clippy

Signed-off-by: joshmc <[email protected]>
@jmcconnell26 jmcconnell26 force-pushed the ISSUE-16-RemoveCargoCoreUsageFromScan branch from de5a5f1 to bacd879 Compare November 14, 2020 09:23
@anderejd anderejd merged commit 975e3f6 into geiger-rs:master Nov 14, 2020
@jmcconnell26 jmcconnell26 deleted the ISSUE-16-RemoveCargoCoreUsageFromScan branch November 14, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants