Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking API change introduced in v0.4.6 #203

Closed
rbost opened this issue Apr 19, 2021 · 0 comments · Fixed by #204
Closed

Breaking API change introduced in v0.4.6 #203

rbost opened this issue Apr 19, 2021 · 0 comments · Fixed by #204

Comments

@rbost
Copy link
Contributor

rbost commented Apr 19, 2021

The refactoring of commit 897baa9 created a new module (find) hosting the functions find_unsafe_in_file and find_unsafe_in_string of the geiger crate. As these functions are not re-exported in lib.rs, it changes the call path and requires changing imports (or the calls themselves) in dependent code.

Note that this can be easily identified by comparing the documentation of v0.4.5 with the one of v0.4.6 on docs.rs.

I found this issue when installing cargo-crev which uses this crate.
The fix is a one-liner; I will submit it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant