Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added retries for ext #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CloudSurgeon
Copy link

Fixes #274
Replaces #275

Adds the register->until->retry methodology to the external downloads for the Jenkins install components.

Tested via Travis/Molecule

@geerlingguy
Copy link
Owner

Can you rebase this PR? It looks good to me.

@CloudSurgeon
Copy link
Author

You got it, @geerlingguy

@geerlingguy
Copy link
Owner

@CloudSurgeon - it seems the rebase went a little crazy—it's hard to review this PR as it's showing 15 files changed and a number of commits that I'm guessing weren't yours... can you do another rebase or scrap the branch and re-submit?

@CloudSurgeon
Copy link
Author

@geerlingguy Yeah. Weird. I rebased again and fixed it. The build passes, but Travis threw up on one of the build jobs.

@stale
Copy link

stale bot commented Jun 5, 2020

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Jun 5, 2020
@stale
Copy link

stale bot commented Jun 7, 2020

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role can fail on just one failed attempt to download repo, repo key, or specific Jenkins install
2 participants