Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drush_path for update tasks #37

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Conversation

mglaman
Copy link
Contributor

@mglaman mglaman commented Apr 18, 2017

For issue #36

@mglaman mglaman changed the title Explicitly provide Drupal core root path for Drush Use drush_path for update tasks Apr 20, 2017
@geerlingguy
Copy link
Owner

@mglaman - Can you rebase on master? The test fail is because of a change there.

Also, I see that I used {{ drush_path }} a couple other places, but technically provide no default (yikes!). It's added by the geerlingguy.drush role, but it might be good to fallback to default('drush') if no drush_path is set.

@mglaman
Copy link
Contributor Author

mglaman commented Apr 20, 2017

@geerlingguy rebased. I'll admit, figuring out where to put default('drush') is above my head. I see {{ drush_path }} isused in build makefile as well.

@geerlingguy
Copy link
Owner

No problem, I'll create a follow-up, as this is kinda low priority, since it's highly likely if you use this role, you'll use geerlingguy.drush as well and it will never be a problem. Else, you can just set drush_path manually if needed.

@geerlingguy
Copy link
Owner

Created a follow-up issue #39

@geerlingguy geerlingguy merged commit c77c6a3 into geerlingguy:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants