Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reorder properties when plotting FeatureCollection #328

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Oct 13, 2024

I did the simplest fix possible. Considering the amount of data displayed at once on a graph are limited I enforce the order of properties in both plot_by_feature and plot_by_properties to match the insertion order destroyed by GEE.

image

image

Fix #320

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (c73959d) to head (013a849).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   91.08%   91.10%   +0.02%     
==========================================
  Files          27       27              
  Lines        1357     1361       +4     
  Branches       66       66              
==========================================
+ Hits         1236     1240       +4     
  Misses        105      105              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@12rambau 12rambau merged commit 2b62e9e into main Oct 13, 2024
12 checks passed
@12rambau 12rambau deleted the order branch October 13, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maintain order when plotting data from FeatureCollection
1 participant