Remove the encoding cache #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg_encoding_to_char() is index based and rb_enc_find() is st_table based, so they are fast. In addition move the dominant UTF-8 encoding to the very first in the encoding map, so that no loop is necessary. This cache was only used at connection setup and when calling encoding getter/setter, so that no practical performance impact is expected. Removing the cache makes connection setup thread safe. This is required to make ruby-pg ractor ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_encoding_to_char() is index based and rb_enc_find() is st_table based, so they are fast. In addition move the dominant UTF-8 encoding to the very first in the encoding map, so that no loop is necessary.
This cache is only used at connection setup and when calling encoding getter/setter, so that no practical performance impact is expected.
Removing the cache makes connection setup thread safe. This is required to make ruby-pg ractor ready.