Silence implicit fallthrough warning on newer GCC versions #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing on Alpine 3.13 (which has gcc 10.2.1) and 3.17 (which has gcc 12.2.1), the following warning was printed during the builds:
This pull request address this by ignoring
-Wimplicit-fallthrough
inlibgearman-server/plugins/protocol/http/protocol.cc
.I used a variation on the Dockerfile in this comment with the modified
server.cc
file to test these changes.